From 8dad236d18ac98f1d672a5cafe08486cb239db5e Mon Sep 17 00:00:00 2001 From: Daniel Mendler Date: Mon, 8 Nov 2021 12:17:03 +0100 Subject: Add support for :company-deprecated completion metadata --- README.org | 5 +++-- corfu.el | 48 ++++++++++++++++++++++++++++++------------------ 2 files changed, 33 insertions(+), 20 deletions(-) diff --git a/README.org b/README.org index da3ed4e..6eef653 100644 --- a/README.org +++ b/README.org @@ -47,7 +47,8 @@ - Deferred completion style highlighting for performance. - Jumping to location/documentation of current candidate. - Show candidate documentation/signature string in the echo area. - - Support for ~annotation-function~ and ~affixation-function~. + - Deprecated candidates are crossed out in the display. + - Support for annotations (~annotation-function~, ~affixation-function~). * Configuration @@ -157,7 +158,7 @@ - Corfu falls back to the default Completion buffer on non-graphical displays, since Corfu requires child frames. - The abort handling could be improved, for example the input could be undone. - - Some Company metadata extensions are not supported (~company-deprecated~, ~company-kind~, ~company-match~). + - Some Company metadata extensions are not supported (~company-kind~, ~company-match~). - No sorting by history, since ~completion-at-point~ does not maintain a history (See branch =history= for a possible solution). diff --git a/corfu.el b/corfu.el index fbc428a..942940e 100644 --- a/corfu.el +++ b/corfu.el @@ -154,6 +154,10 @@ completion began less than that number of seconds ago." '((t :inherit completions-annotations)) "Face used for annotations.") +(defface corfu-deprecated + '((t :strike-through t)) + "Face used for deprecated candidates.") + (defvar corfu-map (let ((map (make-sparse-keymap))) (define-key map [remap beginning-of-buffer] #'corfu-first) @@ -559,24 +563,32 @@ completion began less than that number of seconds ago." (interactive) (completion-in-region-mode -1)) -(defun corfu--affixate (candidates) - "Annotate CANDIDATES with annotation function." - (if-let (aff (or (corfu--metadata-get corfu--metadata 'affixation-function) - (plist-get corfu--extra :affixation-function))) - (funcall aff candidates) - (if-let (ann (or (corfu--metadata-get corfu--metadata 'annotation-function) - (plist-get corfu--extra :annotation-function))) - (mapcar (lambda (cand) - (let ((suffix (or (funcall ann cand) ""))) - (list cand "" - ;; The default completion UI adds the `completions-annotations' face - ;; if no other faces are present. We use a custom `corfu-annotations' - ;; face to allow further styling which fits better for popups. - (if (text-property-not-all 0 (length suffix) 'face nil suffix) - suffix - (propertize suffix 'face 'corfu-annotations))))) - candidates) - (mapcar (lambda (cand) (list cand "" "")) candidates)))) +(defun corfu--affixate (cands) + "Annotate CANDS with annotation function." + (setq cands + (if-let (aff (or (corfu--metadata-get corfu--metadata 'affixation-function) + (plist-get corfu--extra :affixation-function))) + (funcall aff cands) + (if-let (ann (or (corfu--metadata-get corfu--metadata 'annotation-function) + (plist-get corfu--extra :annotation-function))) + (mapcar (lambda (cand) + (let ((suffix (or (funcall ann cand) ""))) + (list cand "" + ;; The default completion UI adds the `completions-annotations' face + ;; if no other faces are present. We use a custom `corfu-annotations' + ;; face to allow further styling which fits better for popups. + (if (text-property-not-all 0 (length suffix) 'face nil suffix) + suffix + (propertize suffix 'face 'corfu-annotations))))) + cands) + (mapcar (lambda (cand) (list cand "" "")) cands)))) + (when-let (dep (plist-get corfu--extra :company-deprecated)) + (mapc (pcase-lambda ((and x `(,c . ,_))) + (when (funcall dep c) + (setcar x (setq c (substring c))) + (add-face-text-property 0 (length c) 'corfu-deprecated 'append c))) + cands)) + cands) ;; XXX Do not use `completion-metadata-get' in order to avoid Marginalia. ;; The Marginalia annotators are way to heavy for the Corfu popup! -- cgit v1.0