diff options
| author | Daniel Mendler <mail@daniel-mendler.de> | 2022-11-24 14:51:06 +0100 |
|---|---|---|
| committer | Daniel Mendler <mail@daniel-mendler.de> | 2022-11-24 14:51:06 +0100 |
| commit | 4236473373428b7a7e22c19b2aaf6202e4d864db (patch) | |
| tree | d0600faa038e37b2303ec8231b95e2ea209c3f6b | |
| parent | 605e5bfc7960eaf6001d47192a1f7401effa463c (diff) | |
Expand comment
| -rw-r--r-- | extensions/corfu-popupinfo.el | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/extensions/corfu-popupinfo.el b/extensions/corfu-popupinfo.el index bb1dd42..79dda00 100644 --- a/extensions/corfu-popupinfo.el +++ b/extensions/corfu-popupinfo.el @@ -235,8 +235,11 @@ all values are in pixels relative to the origin. See ;; since lines will get wrapped. (when (<= (car size) max-width) (cons (+ margin (car size)) - ;; Ensure that popup has at least a height of 1, - ;; which is the minimum frame height (#261). + ;; XXX HACK: Ensure that popup has at least a height of 1, + ;; which is the minimum frame height (#261). Maybe we + ;; should ask upstream how smaller frames can be created. + ;; I only managed to create smaller frames by setting + ;; `window-safe-min-height' to 0, which feels problematic. (min (max (cdr size) lh) max-height)))))) (cons (+ margin max-width) max-height)))) @@ -383,7 +386,7 @@ the candidate popup, its value is 'vertical, 'right or 'left." corfu-popupinfo--lock-dir area-d corfu-popupinfo--candidate candidate corfu-popupinfo--coordinates new-coords) - ;; HACK: Force margin update. For some reason, the call to + ;; XXX HACK: Force margin update. For some reason, the call to ;; `set-window-buffer' in `corfu--make-frame' is not effective the ;; first time. Why does Emacs have all these quirks? (when margin-quirk |