pdf-tools.git, branch v0.99 Unnamed repository; edit this file 'description' to name the repository. Enable testing against MacOS in CI/CD! 2022-10-07T14:04:45+00:00 Vedang Manerikar ved.manerikar@gmail.com 2022-10-06T12:45:55+00:00 d6980bc3273e1cf1a73feee6bb523d1568405685 This is pretty cool, I hope it works! 🤞 It uses the `macos` orb provided by CircleCI, as documented here: https://circleci.com/docs/using-macos This commit also rewrites the older anchor style common steps into the newer command syntax, which is more readable. The command syntax is documented here: https://circleci.com/docs/configuration-reference#commands Installing pre-reqs on MacOS via `brew` was non-trivial. This is mainly because of the `sed` command used in the `Makefile`. It isn't a problem normally because it is only used for packaging, which is done on Melpa Relates to: #98 
This is pretty cool, I hope it works! 🤞 It uses the `macos` orb
provided by CircleCI, as documented here:
https://circleci.com/docs/using-macos

This commit also rewrites the older anchor style common steps into the
newer command syntax, which is more readable. The command syntax is
documented here:
https://circleci.com/docs/configuration-reference#commands

Installing pre-reqs on MacOS via `brew` was non-trivial. This is
mainly because of the `sed` command used in the `Makefile`. It isn't a
problem normally because it is only used for packaging, which is done
on Melpa

Relates to: #98
Add make targets to start / stop the podman VM 2022-10-06T10:39:55+00:00 Vedang Manerikar ved.manerikar@gmail.com 2022-10-06T10:30:10+00:00 53506771c42e0456ee909aa8e0a589233fd1f1ef This is just a convenience wrapper for me 
This is just a convenience wrapper for me
Speed up server testing by keeping the containers around 2022-10-06T10:39:44+00:00 Vedang Manerikar ved.manerikar@gmail.com 2022-10-06T10:28:22+00:00 e6d1df44a1a49e9c35c0153bbe219a7303c3d762 This allows re-using containers, saving a tremendous amount of time. The drawback here is that any environment change (on the docker / podman containers side) is not detected. The way to deal with this will be to create a process around major releases where I delete all the containers and re-test from scratch. Relates to: #130 
This allows re-using containers, saving a tremendous amount of time.

The drawback here is that any environment change (on the docker /
podman containers side) is not detected. The way to deal with this
will be to create a process around major releases where I delete all
the containers and re-test from scratch.

Relates to: #130
Revert "Adds translattion of highlight annotations" 2022-10-04T06:02:41+00:00 Vedang Manerikar ved.manerikar@gmail.com 2022-10-04T06:02:41+00:00 a4905d8352437905e6ba1d923cd24ad260c92030 This reverts commit 0107f80dcf268d08ac075b01729820062c0fbd67 The reason for doing this is explained by @vizs in #143, copying the message here: Andreas wrote the function `annotation_translate_quadrilateral`[^1][^2] to fix misplaced annotations due to the then bug in `glib`. This misplacement bug can be seen in the images posted in issue politza/pdf-tools#577, along with PDFs in which the bug can be reproduced. This lack of translation in the `glib` backend was fixed in `poppler 0.86.0` but the workaround was still left hanging in `epdfinfo.c` which brings us to today where this unneeded translation bites our back. I commented out the calls to `annotation_translate_quadrilateral` in `epdinfo.c` and to my surprise, there were no misplaced translations in files which displayed the misplacing behaviour and in files which did not have this behaviour. [1]: https://github.com/politza/pdf-tools/commit/0107f80dcf268d08ac075b01729820062c0fbd67 [2]: politza/pdf-tools#122 Closes: #143 Closes: #146 
This reverts commit 0107f80dcf268d08ac075b01729820062c0fbd67

The reason for doing this is explained by @vizs in #143, copying the
message here:

Andreas wrote the function
`annotation_translate_quadrilateral`[^1][^2] to fix misplaced
annotations due to the then bug in `glib`. This misplacement bug can
be seen in the images posted in issue politza/pdf-tools#577, along
with PDFs in which the bug can be reproduced.

This lack of translation in the `glib` backend was fixed in `poppler
0.86.0` but the workaround was still left hanging in `epdfinfo.c`
which brings us to today where this unneeded translation bites our
back. I commented out the calls to
`annotation_translate_quadrilateral` in `epdinfo.c` and to my
surprise, there were no misplaced translations in files which
displayed the misplacing behaviour and in files which did not have
this behaviour.

[1]:
https://github.com/politza/pdf-tools/commit/0107f80dcf268d08ac075b01729820062c0fbd67
[2]: politza/pdf-tools#122

Closes: #143
Closes: #146
Add non-transparent text selection to known problems 2022-10-03T09:36:25+00:00 orgtre orgtre@posteo.net 2022-09-19T16:51:58+00:00 aec8ecd0066ba2cbfefed1330a71deada89f5b5a Including a function which implements a work-around. 
Including a function which implements a work-around.
Address some byte-compiler warnings 2022-10-03T09:17:00+00:00 Vedang Manerikar ved.manerikar@gmail.com 2022-10-03T09:08:28+00:00 2ce06dd3e8c6eac2bc579c2a73b7bf7f580ad6dc * lisp/pdf-annot.el (pdf-annot-run-modified-hooks): Use cl-case instead of cl-ecase, as the latter does not support t/otherwise clauses. Remove nil clause which never matches. See https://bugs.gnu.org/51368. (pdf-annot-edit-contents-finalize): * lisp/pdf-sync.el (pdf-sync-minor-mode): Mark up symbols `like-this', to avoid having the apostrophe interpreted as a closing single quote. Remove redundant backslashes. (pdf-sync-synctex-file-name): Use line-beginning-position in place of point-at-bol, which is deprecated in Emacs 29. * lisp/pdf-util.el: Autoload list-colors-duplicates before its use in pdf-util-color-completions, as facemenu is not preloaded since Emacs 28. (pdf-util-hexcolor): Use ash in place of lsh, which is deprecated in Emacs 29. (pdf-util-convert): Fix docstring markup and indentation. * lisp/pdf-virtual.el (pdf-virtual-define-adapter): Refill generated docstring to avoid exceeding 80 column warning threshold. Relates to: #26 Relates to: #80 Closes: #150 
* lisp/pdf-annot.el (pdf-annot-run-modified-hooks): Use cl-case
instead of cl-ecase, as the latter does not support t/otherwise
clauses.  Remove nil clause which never matches.
See https://bugs.gnu.org/51368.
(pdf-annot-edit-contents-finalize):
* lisp/pdf-sync.el (pdf-sync-minor-mode): Mark up symbols
`like-this', to avoid having the apostrophe interpreted as a closing
single quote.  Remove redundant backslashes.
(pdf-sync-synctex-file-name): Use line-beginning-position in place
of point-at-bol, which is deprecated in Emacs 29.
* lisp/pdf-util.el: Autoload list-colors-duplicates before its use
in pdf-util-color-completions, as facemenu is not preloaded since
Emacs 28.
(pdf-util-hexcolor): Use ash in place of lsh, which is deprecated in
Emacs 29.
(pdf-util-convert): Fix docstring markup and indentation.
* lisp/pdf-virtual.el (pdf-virtual-define-adapter): Refill generated
docstring to avoid exceeding 80 column warning threshold.

Relates to: #26
Relates to: #80
Closes: #150
Fix nix-shell pkg-config dependency name 2022-10-03T08:42:46+00:00 Mario Rodas marsam@users.noreply.github.com 2022-09-26T04:20:00+00:00 a316013151b4e50d0e644bb68c6a94f58d1fd7d5 Recently nixpkgs removed the `pkgconfig` alias[^1], which broke the build with `nix-shell`. [^1]: https://github.com/NixOS/nixpkgs/pull/192681 Closes: #153 Closes: #158 
Recently nixpkgs removed the `pkgconfig` alias[^1], which broke the
build with `nix-shell`.

[^1]: https://github.com/NixOS/nixpkgs/pull/192681

Closes: #153
Closes: #158
Fix: misuse of cl-ecase 2022-10-03T08:42:28+00:00 İ. Göktuğ Kayaalp self@gkayaalp.com 2022-10-02T22:19:49+00:00 49078c71f1ae9e85e719029a3e5e5f5e10509017 The `cl-ecase` macro does not support default cases (‘otherwise’ or ‘t’), and the cl-case macro requires the default case to be the last clause, which a recent change to Emacs rendered a macro expansion error[^1], thus preventing the module from loading (and potentially signalling error in the init process). Furthermore, `cl-ecase` expands to a `cl-case` form with a trailing special flag clause, so the appearance of a ‘t’ or ‘otherwise’ clause in a `cl-ecase` call will always result in this error being triggered. I thus replace the apparently futile call to `cl-ecase` with an equivalent null check and a call to `cl-case`, which fixes both issues. I replaced `cl-ecase` with `cl-case` because the former form had both a t-check and a nil-check, which meant the error case was impossible to be triggered. [^1]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=51368 Closes: #159 Closes: #154 Closes: #157 
The `cl-ecase` macro does not support default cases (‘otherwise’ or
‘t’), and the cl-case macro requires the default case to be the last
clause, which a recent change to Emacs rendered a macro expansion
error[^1], thus preventing the module from loading (and potentially
signalling error in the init process).

Furthermore, `cl-ecase` expands to a `cl-case` form with a trailing
special flag clause, so the appearance of a ‘t’ or ‘otherwise’ clause
in a `cl-ecase` call will always result in this error being triggered.

I thus replace the apparently futile call to `cl-ecase` with an
equivalent null check and a call to `cl-case`, which fixes both issues.
I replaced `cl-ecase` with `cl-case` because the former form had both a
t-check and a nil-check, which meant the error case was impossible to
be triggered.

[^1]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=51368

Closes: #159
Closes: #154
Closes: #157
Fix: Warnings and <26.1 code 2022-10-02T14:06:55+00:00 Vedang Manerikar ved.manerikar@gmail.com 2022-10-02T14:06:55+00:00 45b0570677571c2373428b8af31a65129715f5cd Fix warnings and remove code for supporting older versions of Emacs from the following files: 1. `pdf-annot.el` Relates to: #26 
Fix warnings and remove code for supporting older versions of Emacs
from the following files:
1. `pdf-annot.el`

Relates to: #26
Revert "synctex_parser: fix vasprintf() not exists in non-GNU environment (#134)" 2022-08-23T05:13:59+00:00 Vedang Manerikar ved.manerikar@gmail.com 2022-08-23T05:13:59+00:00 1a0a30c54dc3effdba4781a2983115d4b6993260 This reverts commit bea5ddb9fc234b48db6df3dcb66d75e76bec00c8 because `pdf-tools` compilation is broken. Closes: #141 Reopens: #134 
This reverts commit bea5ddb9fc234b48db6df3dcb66d75e76bec00c8 because
`pdf-tools` compilation is broken.

Closes: #141
Reopens: #134